On Fri, 29 Jul 2005 13:55:23 -0700,
George Anzinger <george@mvista.com> wrote:
> This patch adds a notify to the die_nmi notify that the system
> is about to be taken down. If the notify is handled with a
> NOTIFY_STOP return, the system is given a new lease on life.
>
> void die_nmi (struct pt_regs *regs, const char *msg)
> {
>+ if (notify_die(DIE_NMIWATCHDOG, "nmi_watchdog", regs,
>+ 0, 0, SIGINT) == NOTIFY_STOP)
>+ return;
>+
> spin_lock(&nmi_print_lock);
> /*
> * We are in trouble anyway, lets at least try
Minor nitpick. die_nmi() already gets a message passed in to
distinguish between different types of nmi. Pass that message to
notify_die(), on the off chance that the notified routines can use that
difference.
Also your patch adds a trailing whitespace on the call to notify_die().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
