On Thu, Apr 9, 2015 at 9:59 AM, Peter Zijlstra <pet...@infradead.org> wrote: > > I was a little surprised myself it worked, but its a constant after > all so it 'should'.
Well, it should actually work for non-constants too, even when that 'idx' isn't inlined to one of the fixed constants. So even if this will ever hit the "seq & 1" case for lookup, it should all work. It's just an expression, after all. All that is really required is that you can do '&(x->y)' on it, where 'x' is the type, and 'y' is the "member". It's just unusual, which I think makes it slightly harder to read for a *human* just because it breaks the normal pattern of those things. But there's nothing technically wrong with it. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/