On Tue, Apr 14, 2015 at 05:35:12PM +0200, Nicolas Dichtel wrote: > Le 14/04/2015 17:26, Patrick McHardy a écrit : > >On 14.04, Honggang Li wrote: > [snip] > >>- return vlan->lowerdev->ifindex; > >>+ if (vlan && vlan->lowerdev) > >>+ return vlan->lowerdev->ifindex; > > > >That is completely useless. vlan (=netdev_priv) can not be NULL as > >netdev_priv() never returns NULL and vlan->lowerdev is always valid > >because a macvlan wouldn't make much sense otherwise. > > > And I suspect that it is the same for ipvlan and dsa.
I agree about DSA. I don't see any way this could happen. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
