From: Wei Yongjun <yongjun_...@trendmicro.com.cn>

In case of error, the functions platform_get_resource() and kmalloc()
returns NULL not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
---
 arch/powerpc/sysdev/ppc4xx_hsta_msi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/sysdev/ppc4xx_hsta_msi.c 
b/arch/powerpc/sysdev/ppc4xx_hsta_msi.c
index f366d2d..49e24f5 100644
--- a/arch/powerpc/sysdev/ppc4xx_hsta_msi.c
+++ b/arch/powerpc/sysdev/ppc4xx_hsta_msi.c
@@ -130,7 +130,7 @@ static int hsta_msi_probe(struct platform_device *pdev)
        int irq, ret, irq_count;
 
        mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (IS_ERR(mem)) {
+       if (!mem) {
                dev_err(dev, "Unable to get mmio space\n");
                return -EINVAL;
        }
@@ -155,7 +155,7 @@ static int hsta_msi_probe(struct platform_device *pdev)
                goto out;
 
        ppc4xx_hsta_msi.irq_map = kmalloc(sizeof(int) * irq_count, GFP_KERNEL);
-       if (IS_ERR(ppc4xx_hsta_msi.irq_map)) {
+       if (!ppc4xx_hsta_msi.irq_map) {
                ret = -ENOMEM;
                goto out1;
        }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to