On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > > +struct tee_device { > > + char name[TEE_MAX_DEV_NAME_LEN]; > > + const struct tee_desc *desc; > > + struct device *dev; > > No, please embed the device in your structure, don't have a pointer to > it.
Greg, "dev" here is not a locally allocated device, but the parent device. It's actually the same as struct tee_device.miscdev.parent, which could be used instead and this member deleted. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/