On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote:
> Since perf diff only support stdio output, TUI fields are only accessed
> from perf report (or perf top).  So add new struct hist_entry_tui and
> move those fields into them.  And include it as an union member.
> 

SNIP

>  
> -     /* XXX These two should move to some tree widget lib */
> -     u16                     row_offset;
> -     u16                     nr_rows;
> -
>       bool                    init_have_children;
>       char                    level;
>       u8                      filtered;
> +     union {
> +             struct hist_entry_diff  diff;
> +             struct hist_entry_tui   tui;
> +     };

could you please add the comment from changelog in here,
so it's easy to figure this out in the future 

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to