On Mon, Apr 20, 2015 at 05:08:37PM +0100, Linus Torvalds wrote: > On Mon, Apr 20, 2015 at 8:45 AM, Andrey Ryabinin <[email protected]> > wrote: > > > > Commit 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking") > > started to use smp_load_acquire() to load 2-bytes csd->flags. > > That crashes arm64 kernel during the boot. > > Ahh. I don't disagree with your patch, but we should just make > csd->flags be an "int" regardless of this issue. > > There is absolutely no reason to try to use 16-bit words. It doesn't > save us any space (alignment), and it's just a *bad* idea to depend on > any kind of atomicity of 16-bit entities. Bytes, yes. Words, yes. But > 16-bit half-words? There's no point. > > So I'll make it "unsigned int" instead of "u16". > > But as said, the ARM64 patch definitely is a good idea regardless.
Sounds good to me and means I can leave the pull for a day or two to see if any other arm64 fixes queue up. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
