On Wed, Apr 22, 2015 at 03:21:43PM +0000, Devesh Sharma wrote: > > -----Original Message----- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Doug Ledford > > Sent: Wednesday, April 22, 2015 8:33 PM > > To: Michael Wang > > Cc: Roland Dreier; Sean Hefty; linux-r...@vger.kernel.org; linux- > > ker...@vger.kernel.org; h...@dev.mellanox.co.il; Tom Tucker; Steve Wise; > > Hoang-Nam Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal > > Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira Weiny; Tom Talpey; > > Jason > > Gunthorpe > > Subject: Re: [PATCH v5 01/27] IB/Verbs: Implement new callback > > query_transport() > > > > On Mon, 2015-04-20 at 10:32 +0200, Michael Wang wrote: > > > Add new callback query_transport() and implement for each HW. > > > > The more I think about it, the more I think we need to eliminate this patch > > entirely. > > > > The problem here is that, if we follow my suggestion, then we are going to > > eliminate the query as an API function and replace the information it gives > > us > > with a static port attribute bitmap. If we do this patch, then reform this > > patch > > to my idea later, we introduce a very short lived API/ABI change in the > > kernel > > module interface that serves absolutely no purpose. Instead, let's do the > > bitmap creation first, update the drivers to properly set the bitmap, then > > do all > > of the remaining reforms you have here using that bitmap and completely skip > > the > > query_transport() API item that will no longer serve a purpose. > > Any vendor device that registers with IB stack already has capability flags, > are you referring to the same as bit maps? > Is it possible to use same as bitmaps you are referring to? I am trying to > understand you complete idea.
The idea was to use additional bit maps. https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html Ira -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
