On Fri, 2015-04-24 at 09:56 -0600, Toshi Kani wrote: > On Fri, 2015-04-17 at 21:35 -0400, Dan Williams wrote: > > Most configuration of the nd-subsystem is done via nd-sysfs. However, > > the NFIT specification defines a small set of messages that can be > > passed to the subsystem via platform-firmware-defined methods. The > > command set (as of the current version of the NFIT-DSM spec) is: > > > > NFIT_CMD_SMART: media health and diagnostics > > NFIT_CMD_GET_CONFIG_SIZE: size of the label space > > NFIT_CMD_GET_CONFIG_DATA: read label > > NFIT_CMD_SET_CONFIG_DATA: write label > > NFIT_CMD_VENDOR: vendor-specific command passthrough > > NFIT_CMD_ARS_CAP: report address-range-scrubbing capabilities > > NFIT_CMD_START_ARS: initiate scrubbing > > NFIT_CMD_QUERY_ARS: report on scrubbing state > > NFIT_CMD_SMART_THRESHOLD: configure alarm thresholds for smart events > > "nd/bus.c" provides two features, 1) the top level ND bus driver which > is the central part of the ND, and 2) the ioctl interface specific to > the example-DSM-interface. I think the example-DSM-specific part should > be put into an example-DSM-support module, so that the ND can support > other _DSMs as necessary. Also, _DSM needs to be handled as optional.
And the same for "nd/acpi.c", which is 1) the ACPI0012 handler, and 2) the example-DSM-support module. I think they need to be separated. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/