On Fri, 24 Apr 2015, Josh Poimboeuf wrote: > > #if defined(CONFIG_RANDOMIZE_BASE) > > - /* KASLR is enabled, disregard old_addr from user */ > > - func->old_addr = 0; > > + /* If KASLR has been enabled, adjust old_addr accordingly */ > > + if (kaslr_enabled()) > > + func->old_addr += klp_vmlinux_relocation_offset(); > > The old_addr field is optional, where a value of 0 means "lookup the > address in kallsyms". So its value should only be adjusted if old_addr > is already non-zero. Otherwise the zero value will be replaced with a > bad address and it will mistakenly call klp_verify_vmlinux_symbol() with > the bad address instead of klp_find_object_symbol().
Fair enough, good point, will take this into account in v3. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
