On Tue, Apr 28, 2015 at 7:33 PM, Josh Cartwright <jo...@ni.com> wrote: > On Tue, Apr 28, 2015 at 09:14:26AM +0530, punnaiah choudary kalluri wrote: >> On Tue, Apr 28, 2015 at 8:52 AM, Brian Norris <computersforpe...@gmail.com> >> wrote: >> > On Tue, Apr 28, 2015 at 08:18:12AM +0530, punnaiah choudary kalluri wrote: >> >> On Tue, Apr 28, 2015 at 4:53 AM, Brian Norris >> >> <computersforpe...@gmail.com> wrote: > [..] >> >> Agree that read_buf need not be returning raw data always including >> >> my new driver for arasan nand flash controller. >> > >> > I agree with that. At the moment, chip->read_buf() really has very >> > driver-specific meaning. Not sure if that's really a good thing, but >> > it's the way things are... >> > >> >> http://lkml.iu.edu/hypermail/linux/kernel/1504.2/00313.html >> > >> > In the half a minute I just spent looking at this (I may review it >> > properly later), I noted a few things: >> > >> > 1. you don't implement ecc.read_page_raw(); this means we'll probably >> > have trouble supporting on-die ECC with your driver, among other things >> >> On-die ECC is optional as long as the controller has better ecc coverage. >> The arasan controller supports up to 24 bit ecc. There is no point to use >> on-die ECC and will always use hw ecc even for On-die ecc devices. > > Maybe this is true of the controller instantiated in the Zynq MPSoC > chips, but the Zynq 7000 series SMC is documented to support only 1-bit > ECC.
True. SMC controller in zynq supports only 1 -bit ECC. One can use on-die ECC devices and turn of the controller ECC for better ECC coverage. I am also exploring the options to use these patches with the pl353 driver in a generic way and acceptable to all. Regards, Punnaiah > > (Which is why we're looking at your pl353 driver and this set). > > Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/