On Wed, Apr 29, 2015 at 02:44:21PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <[email protected]>
So this one is missing a commit message too but we need to talk about
this. Why are we adding __read_mostly in the macro? This would put every
param declared this way into __section__(".data..read_mostly") and I'm
not really convinced that is needed.
Those setup params get accessed a couple of times only during boot, in
non-critical paths so we don't really care.
If you care about pat_enabled being read a lot, you could do:
int __read_mostly pat_enabled;
only for it.
But for every param declared this way? I'm not sure we want that...
> Cc: Andy Walls <[email protected]>
> Cc: Doug Ledford <[email protected]>
> Cc: Andy Lutomirski <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Juergen Gross <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Dave Airlie <[email protected]>
> Cc: Bjorn Helgaas <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: Michael S. Tsirkin <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Luis R. Rodriguez <[email protected]>
> ---
> include/linux/init.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/init.h b/include/linux/init.h
> index 21b6d76..a0385cc 100644
> --- a/include/linux/init.h
> +++ b/include/linux/init.h
> @@ -272,7 +272,7 @@ struct obs_kernel_param {
>
> #define early_param_on_off(str_on, str_off, var, config) \
> \
> - int var = IS_ENABLED(config); \
> + int __read_mostly var = IS_ENABLED(config); \
> \
> static int __init parse_##var##_on(char *arg) \
> { \
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
