> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Luis R. Rodriguez > Sent: Thursday, April 30, 2015 3:25 PM > Subject: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends > ... > - printk(KERN_ERR "%s:%d map pfn expected mapping > type %s" > - " for [mem %#010Lx-%#010Lx], got %s\n", > - current->comm, current->pid, > - cattr_name(want_pcm), > - (unsigned long long)paddr, > - (unsigned long long)(paddr + size - 1), > - cattr_name(pcm)); > + pr_err("%s:%d map pfn expected mapping type %s" > + " for [mem %#010Lx-%#010Lx], got %s\n",
Since the patch joins some other print format strings split across lines (which checkpatch allows), you might want to join this one too. ... > diff --git a/arch/x86/mm/pat_rbtree.c b/arch/x86/mm/pat_rbtree.c ... > failure: > - printk(KERN_INFO "%s:%d conflicting memory types " > + pr_info("%s:%d conflicting memory types " > "%Lx-%Lx %s<->%s\n", current->comm, current->pid, start, > end, cattr_name(found_type), cattr_name(match->type)); and that one. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/