Hi, On Thu, May 7, 2015 at 6:47 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On 05/07/2015 03:09 PM, Doug Anderson wrote: >> >> Right now the dw_wdt uses a spinlock to protect dw_wdt_open(). The >> problem is that while holding the spinlock we call: >> -> dw_wdt_set_top() >> -> dw_wdt_top_in_seconds() >> -> clk_get_rate() >> -> clk_prepare_lock() >> -> mutex_lock() >> >> Locking a mutex while holding a spinlock is not allowed and leads to >> warnings like "BUG: spinlock wrong CPU on CPU#1", among other >> problems. >> >> There's no reason to use a spinlock, so switch to a mutex. >> >> Signed-off-by: Doug Anderson <diand...@chromium.org> > > > Reviewed-by: Guenter Roeck <li...@roeck-us.net>
As Dmitry pointed out in another context, and even better fix is to just remove the spinlock altogether. I'll send up v2... -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
