On 12 May 2015 at 15:02, Shuah Khan <[email protected]> wrote: > On 05/12/2015 03:59 PM, [email protected] wrote: >> From: Tyler Baker <[email protected]> > > This is odd. Did you use git send-email to send the patches?
Yes I did. > > -- Shuah >> >> This patch fixes the INSTALL_RULE to gracefully handle the case where >> TEST_PROGS and TEST_PROGS_EXTENDED and TEST_FILES are not set. In this case, >> install is called without any SOURCE arguments causing make install to fail. >> The proposed fix is to loop over the items in these variables and only call >> install if there is a test artifact present. >> >> Signed-off-by: Tyler Baker <[email protected]> >> --- >> tools/testing/selftests/lib.mk | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index ee412ba..89dd785f 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -13,10 +13,12 @@ run_tests: all >> >> define INSTALL_RULE >> mkdir -p $(INSTALL_PATH) >> - @for TEST_DIR in $(TEST_DIRS); do\ >> + @for TEST_DIR in $(TEST_DIRS); do \ >> cp -r $$TEST_DIR $(INSTALL_PATH); \ >> done; >> - install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) >> $(TEST_FILES) >> + @for ARTIFACT in $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES); >> do \ >> + install -t $(INSTALL_PATH) $$ARTIFACT; \ >> + done; >> endef >> >> install: all >> > > > -- > Shuah Khan > Sr. Linux Kernel Developer > Open Source Innovation Group > Samsung Research America (Silicon Valley) > [email protected] | (970) 217-8978 -- Tyler Baker Tech Lead, LAVA Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
