On Tue, May 12, 2015 at 12:38 PM, Sudeep Holla <[email protected]> wrote: > Commit 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from > devices with an OF node") adds the symlink `of_node` for each device > pointing to it's device tree node while creating/initialising it. > > However the devicetree sysfs is created and setup in of_init which is > executed at core_initcall level. For all the devices created at the core > initcall before of_init, the following error is thrown: > "Error -2(-ENOENT) creating of_node link"
What devices have you seen the problem with? I'd rather see if those devices could now be moved later. > Since the core_initcall is the earliest point where devices get > registered, push initcall level of of_init from core to pure so that > the devicetree sysfs is ready before any devices are registered. Read the definition of pure: * A "pure" initcall has no dependencies on anything else, and purely * initializes variables that couldn't be statically initialized. Rob > Cc: Grant Likely <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Benjamin Herrenschmidt <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Signed-off-by: Sudeep Holla <[email protected]> > --- > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 99764db0875a..8c3d6b04c585 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -210,7 +210,7 @@ static int __init of_init(void) > > return 0; > } > -core_initcall(of_init); > +pure_initcall(of_init); > > static struct property *__of_find_property(const struct device_node *np, > const char *name, int *lenp) > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
