From: Colin Ian King <colin.k...@canonical.com>
static analysis from smatch found a potential null dereference:
drivers/misc/sgi-gru/grutlbpurge.c:320 gru_register_mmu_notifier() error:
potential null dereference 'gms'. (kzalloc returns null)
bail out with -ENOMEM rather than falling through and printing a debug
message that trips a null dereference.
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
drivers/misc/sgi-gru/grutlbpurge.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/misc/sgi-gru/grutlbpurge.c
b/drivers/misc/sgi-gru/grutlbpurge.c
index 2129274..1239800 100644
--- a/drivers/misc/sgi-gru/grutlbpurge.c
+++ b/drivers/misc/sgi-gru/grutlbpurge.c
@@ -315,6 +315,8 @@ struct gru_mm_struct *gru_register_mmu_notifier(void)
err = __mmu_notifier_register(&gms->ms_notifier,
current->mm);
if (err)
goto error;
+ } else {
+ return ERR_PTR(-ENOMEM);
}
}
gru_dbg(grudev, "gms %p, refcnt %d\n", gms,
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
