On Thu, May 14, 2015 at 1:55 PM, Denys Vlasenko <[email protected]> wrote: > "movw %ds,%cx" insn needs a 0x66 prefix, while "movw %ds,%ecx" does not. did you mean 'movl %ds,%ecx' here as is in your patch below?
> Signed-off-by: Denys Vlasenko <[email protected]> > CC: Linus Torvalds <[email protected]> > CC: Steven Rostedt <[email protected]> > CC: Ingo Molnar <[email protected]> > CC: Borislav Petkov <[email protected]> > CC: "H. Peter Anvin" <[email protected]> > CC: Andy Lutomirski <[email protected]> > CC: Oleg Nesterov <[email protected]> > CC: Frederic Weisbecker <[email protected]> > CC: Alexei Starovoitov <[email protected]> > CC: Will Drewry <[email protected]> > CC: Kees Cook <[email protected]> > CC: [email protected] > CC: [email protected] > --- > arch/x86/kernel/entry_64.S | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S > index 62b4c5f..ef2651d 100644 > --- a/arch/x86/kernel/entry_64.S > +++ b/arch/x86/kernel/entry_64.S > @@ -1195,19 +1195,19 @@ ENTRY(xen_failsafe_callback) > /*CFI_REL_OFFSET ds,DS*/ > CFI_REL_OFFSET r11,8 > CFI_REL_OFFSET rcx,0 > - movw %ds,%cx > + movl %ds,%ecx > cmpw %cx,0x10(%rsp) > CFI_REMEMBER_STATE > jne 1f > - movw %es,%cx > + movl %es,%ecx > cmpw %cx,0x18(%rsp) > jne 1f > - movw %fs,%cx > + movl %fs,%ecx > cmpw %cx,0x20(%rsp) > jne 1f > - movw %gs,%cx > + movl %gs,%ecx > cmpw %cx,0x28(%rsp) > jne 1f > /* All segments match their saved values => Category 2 (Bad IRET). */ > movq (%rsp),%rcx > CFI_RESTORE rcx > movq 8(%rsp),%r11 > -- > 1.8.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Thiago Farina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
