Hi Krzysztof, >>> + >>> + if (i == edev->max_supported) >>> + return -EINVAL; >>> >>> if (index < 0 || (edev->max_supported && edev->max_supported <= >>> index)) >>> return -EINVAL; >>> @@ -605,7 +644,7 @@ static void dummy_sysfs_dev_release(struct device *dev) >>> * >>> * Return the pointer of extcon device if success or ERR_PTR(err) if fail >>> */ >>> -struct extcon_dev *extcon_dev_allocate(const char **supported_cable) >>> +struct extcon_dev *extcon_dev_allocate(const enum extcon *supported_cable) >> >> I think you also have to update the documentation. At least for >> {devm}_extcon_dev_allocate but maybe in other places too. Previously >> the documentation states that supported_cable is an array of strings. >> Additionally AFAIU now it must end with EXTCON_NONE. This >> sentinel-like info must be clearly documented.
As you commented, extcon must need to document the update and usage method of extcon core. The mainline kernel includes only the 'Documentation/extcon/porting-android-switch-class'. Namely, the mainline kernel have not included the document showing the usage method of extcon core. So, I'll make the proper document for extcon core as later job. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/