On 05/22/2015 02:56 PM, Andrew Bresticker wrote: > On Thu, May 21, 2015 at 4:57 PM, Ezequiel Garcia > <ezequiel.gar...@imgtec.com> wrote: >> From: Damien Horsley <damien.hors...@imgtec.com> >> >> Correct the critical clock list. The current one is wrong, and may >> fail under some circumstances. >> >> Signed-off-by: Damien Horsley <damien.hors...@imgtec.com> >> Signed-off-by: Ezequiel Garcia <ezequiel.gar...@imgtec.com> > > The commit message could be more descriptive, e.g. explaining which > additional clocks must be enabled at all times and why, especially > since forcing on clocks form the clock driver is very much frowned > upon unless absolutely necessary. Otherwise, > > Reviewed-by: Andrew Bresticker <abres...@chromium.org> >
OK, I'll explain this in detail. Thanks for the review, -- Ezequiel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
