On 05/22/2015 01:58 PM, James Hartley wrote: > > >> -----Original Message----- >> From: abres...@google.com [mailto:abres...@google.com] On Behalf Of >> Andrew Bresticker >> Sent: 22 May 2015 17:50 >> To: Ezequiel Garcia >> Cc: linux-kernel@vger.kernel.org; Linux-MIPS; Daniel Lezcano; >> devicet...@vger.kernel.org; James Hartley; James Hogan; Thomas Gleixner; >> Damien Horsley; Govindraj Raja >> Subject: Re: [PATCH 7/7] mips: pistachio: Allow to enable the external timer >> based clocksource >> >> On Thu, May 21, 2015 at 2:43 PM, Ezequiel Garcia >> <ezequiel.gar...@imgtec.com> wrote: >>> This commit introduces a new config, so the user can choose to enable >>> the General Purpose Timer based clocksource. This option is required >>> to have CPUFreq support. >>> >>> Signed-off-by: Ezequiel Garcia <ezequiel.gar...@imgtec.com> >>> --- >>> arch/mips/Kconfig | 1 + >>> arch/mips/pistachio/Kconfig | 13 +++++++++++++ >>> 2 files changed, 14 insertions(+) >>> create mode 100644 arch/mips/pistachio/Kconfig >>> >>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index >>> f501665..91f6ca0 100644 >>> --- a/arch/mips/Kconfig >>> +++ b/arch/mips/Kconfig >>> @@ -934,6 +934,7 @@ source "arch/mips/jazz/Kconfig" >>> source "arch/mips/jz4740/Kconfig" >>> source "arch/mips/lantiq/Kconfig" >>> source "arch/mips/lasat/Kconfig" >>> +source "arch/mips/pistachio/Kconfig" >>> source "arch/mips/pmcs-msp71xx/Kconfig" >>> source "arch/mips/ralink/Kconfig" >>> source "arch/mips/sgi-ip27/Kconfig" >>> diff --git a/arch/mips/pistachio/Kconfig b/arch/mips/pistachio/Kconfig >>> new file mode 100644 index 0000000..97731ea >>> --- /dev/null >>> +++ b/arch/mips/pistachio/Kconfig >>> @@ -0,0 +1,13 @@ >>> +config PISTACHIO_GPTIMER_CLKSRC >>> + bool "Enable General Purpose Timer based clocksource" >>> + depends on MACH_PISTACHIO >>> + select CLKSRC_PISTACHIO >>> + select MIPS_EXTERNAL_TIMER >> >> Why not just select these in the MACH_PISTACHIO Kconfig entry? Is there any >> harm in always having the Pistachio GPT enabled? > > It does mean that there are less GPT's available for other users, and whilst > I'm not aware of any use cases that currently require all 4, perhaps having > the flexibility is worth it. >
And also, this is only useful if the user wants CPUFreq. Otherwise we have MIPS GIC and R4K for clockevents and clocksource. Not sure why we'd want another one. -- Ezequiel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
