On Fri, May 22, 2015 at 2:16 PM, Elliott, Robert (Server Storage) <[email protected]> wrote: > > >> -----Original Message----- >> From: Linux-nvdimm [mailto:[email protected]] On Behalf Of >> Dan Williams >> Sent: Wednesday, May 20, 2015 3:58 PM >> To: [email protected] >> Cc: [email protected]; [email protected]; [email protected]; >> [email protected]; Dave Chinner; [email protected]; Andy >> Lutomirski; Jens Axboe; [email protected]; H. Peter Anvin; >> [email protected] >> Subject: [PATCH v3 18/21] nd_btt: atomic sector updates >> >> From: Vishal Verma <[email protected]> >> > ... >> diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig >> index 00d9afe9475e..2b169806eac5 100644 >> --- a/drivers/block/nd/Kconfig >> +++ b/drivers/block/nd/Kconfig >> @@ -32,9 +32,25 @@ config BLK_DEV_PMEM >> capable of DAX (direct-access) file system mappings. See >> Documentation/blockdev/nd.txt for more details. >> >> - Say Y if you want to use a NVDIMM described by NFIT >> + Say Y if you want to use a NVDIMM described by ACPI, E820, etc... >> >> config ND_BTT_DEVS >> - def_bool y >> + bool >> + >> +config ND_BTT >> + tristate "BTT: Block Translation Table (atomic sector updates)" >> + depends on LIBND >> + default LIBND >> + select ND_BTT_DEVS > > The ND_BTT option, which is presented during a kernel build, > is missing help text. So is E820_PMEM in patch 3/21. >
Right, but another alternative is hiding the ability to configure it altogether. Perhaps just build them in always. I made them configurable for those kernel size folks that like the ability to throw away things they don't need, but this may be a degree of freedom too far. E820_PMEM is a bit more straightforward, and could use a help comment like "you've already gone through the trouble to turn on X86_PMEM_LEGACY, you had better turn on the driver too, otherwise what's the point" :). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
