> -----Original Message----- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, May 25, 2015 9:47 PM > To: Badola Nikhil-B46172 > Cc: linux-kernel@vger.kernel.org > Subject: Re: [PATCH] drivers:usb:fsl: Replace macros with enumerated type > > On Mon, May 25, 2015 at 11:41:34AM +0530, Nikhil Badola wrote: > > Replace macros with enumerated type to represent usb ip controller > > version > > > > Signed-off-by: Nikhil Badola <nikhil.bad...@freescale.com> > > --- > > Depends on "drivers: usb :fsl: Add support for USB controller version-2.5" > > > > include/linux/fsl_devices.h | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h > > index 2a2f56b..035ead7 100644 > > --- a/include/linux/fsl_devices.h > > +++ b/include/linux/fsl_devices.h > > @@ -20,11 +20,6 @@ > > #define FSL_UTMI_PHY_DLY 10 /*As per P1010RM, delay for UTMI > > PHY CLK to become stable - 10ms*/ > > #define FSL_USB_PHY_CLK_TIMEOUT 10000 /* uSec */ > > -#define FSL_USB_VER_OLD 0 > > -#define FSL_USB_VER_1_6 1 > > -#define FSL_USB_VER_2_2 2 > > -#define FSL_USB_VER_2_4 3 > > -#define FSL_USB_VER_2_5 4 > > > > #include <linux/types.h> > > > > @@ -52,6 +47,14 @@ > > * > > */ > > > > +enum fsl_usb2_controller_ver { > > + FSL_USB_VER_OLD, > > + FSL_USB_VER_1_6, > > + FSL_USB_VER_2_2, > > + FSL_USB_VER_2_4, > > + FSL_USB_VER_2_5, > > Don't you need to specify the value here just to be "sure" the compiler gets > it correct, and so that someone knows they can't add a new value in the > middle?
Will specify the value in the next patch version > > And why didn't you cc: the linux-usb mailing list? I will cc: linux-usb mailing list while sending all the patches in a patchset -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
