Hi,
On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote:
> Greg KH <gre...@linuxfoundation.org> writes:
>
> > If there are other bus drivers that do this, I'll go fix them up,
> > pointers to those files would be appreciated.
>
> git grep -E 'if .*\.p\W' found a couple of interesting candidates you
> might want to check out:
>
> drivers/i2c/i2c-core.c: if (unlikely(WARN_ON(!i2c_bus_type.p))) {
> drivers/i2c/i2c-core.c: if (unlikely(WARN_ON(!i2c_bus_type.p)))
> drivers/spmi/spmi.c: if (WARN_ON(!spmi_bus_type.p))
>
> And this looks somewhat suspicious too, but could very well be OK for
> all I know (very close to nothing :)
>
> drivers/gpio/gpiolib-sysfs.c: if (!gpio_class.p) {
> drivers/gpio/gpiolib-sysfs.c: if (!gpio_class.p)
I think we need a clear statement on how to proceed on this case. With
Linux, the code is the documentation most of times. I gave a reviewed-by
feedback based on seeing other examples following the same approach.
What would be the correct way?
Thanks,
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
