On 2015.5.28 19:07, David Vrabel wrote: > On 06/05/15 02:47, Ouyang Zhaowei (Charles) wrote: >> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM >> which has multi-cpu >> >> The hypervisor continues assuming that vcpu_info is stored in per-cpu data >> which was set up by xen_vcpu_setup(), >> while on canceled suspend, the call to xen_hvm_init_shared_info() will make >> the guest think that vcpu_info >> is in the shared page. This will cause non-boot cpus keep checking a wrong >> vcpu_info address and can not handle >> irqs any more after suspend canceled, for example after we do "xl save >> -c/restore", PVOPS VM can not be resumed >> as the cpus can not finish their irqs. >> >> >> Signed-off-by: Charles Ouyang <[email protected]> >> Reviewed-by: Boris Ostrovsky <[email protected]> >> Reviewed-by: David Vrabel <[email protected]> > > 1. I don't think I offered a reviewed-by tag for this patch > 2. You did not Cc the xen-devel mailing list on this patch. > 3. The patch is white-space damaged. > 4. The commit message has lines longer than ~72 chars.
Sorry about that, this is my first time to send patch, and I didn't notice that it was white-space damaged. I'll modify the patch and commit message as you applied and Cc Xen-devel mailing list. Thanks Ouyang Zhaowei > > But I've applied this to for-linus-4.1b anyway, thanks. > > David > > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
