So boot_cpu_id is apic id of BSP. Anyway sync_tsc(...) there is master and MASTER..., but value are all 0.
YH On 8/11/05, Eric W. Biederman <[EMAIL PROTECTED]> wrote: > Ok being impatient not wanting this tiny bug to be forgotten for > 2.6.13. Linus please apply this micro patch. > > > > static void __cpuinit tsc_sync_wait(void) > > > { > > > if (notscsync || !cpu_has_tsc) > > > return; > > > - printk(KERN_INFO "CPU %d: Syncing TSC to CPU %u.\n", smp_processor_id(), > > > - boot_cpu_id); > > > - sync_tsc(); > > > + sync_tsc(boot_cpu_id); > > > > I actually found a bug in this today. This should be sync_tsc(0), not > > sync_tsc(boot_cpu_id) > > Can you just fix it in your tree or should I submit a new patch? > > > > -Andi > > Oops. I knew I didn't have the physical versus logical cpu identifiers right > when I generated that patch. It's not nearly as bad as I feared at the time > though. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > --- > > arch/x86_64/kernel/smpboot.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > 5192895f71c7eff7e1335cd9d6a775dda2bb5d52 > diff --git a/arch/x86_64/kernel/smpboot.c b/arch/x86_64/kernel/smpboot.c > --- a/arch/x86_64/kernel/smpboot.c > +++ b/arch/x86_64/kernel/smpboot.c > @@ -334,7 +334,7 @@ static void __cpuinit tsc_sync_wait(void > { > if (notscsync || !cpu_has_tsc) > return; > - sync_tsc(boot_cpu_id); > + sync_tsc(0); > } > > static __init int notscsync_setup(char *s) > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/