On Tue, Jun 02, 2015 at 04:04:22PM +0300, Jarkko Sakkinen wrote: > +/* A string buffer type for constructing TPM commands. This is based on the > + * code in security/keys/trusted.h. > + */ > + > +#define TPM_BUF_SIZE 512 > + > +struct tpm_buf { > + u8 data[TPM_BUF_SIZE];
This should be u32 or u64 to guarentee correct alignment for the casting. > +}; > + > +static inline void tpm_buf_init(struct tpm_buf *buf, u16 tag, u32 ordinal) > +{ > + struct tpm_input_header *head; > + > + head = (struct tpm_input_header *) buf->data; > + > + head->tag = cpu_to_be16(tag); > + head->length = cpu_to_be32(sizeof(*head)); > + head->ordinal = cpu_to_be32(ordinal); > +} > + > +static inline u32 tpm_buf_length(struct tpm_buf *buf) > +{ > + struct tpm_input_header *head = (struct tpm_input_header *) buf->data; > + > + return be32_to_cpu(head->length); > +} > + > +static inline u16 tpm_buf_tag(struct tpm_buf *buf) > +{ > + return be16_to_cpu(*(__be16 *) &buf->data[0]); be16_to_cpup ? Any thought on someday using this for tpm1 as well? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/