On 06/08/2015 03:40 PM, Viresh Kumar wrote:
Migrate arm_global_timer driver to the new 'set-state' interface
provided by the clockevents core, the earlier 'set-mode' interface is
marked obsolete now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

Cc: Srinivas Kandagatla <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Signed-off-by: Viresh Kumar <[email protected]>
---
  drivers/clocksource/arm_global_timer.c | 37 ++++++++++++++++------------------

Acked-by: Daniel Lezcano <[email protected]>

-       clk->set_mode = gt_clockevent_set_mode;
+       clk->set_state_shutdown = gt_clockevent_shutdown;
+       clk->set_state_periodic = gt_clockevent_set_periodic;
+       clk->set_state_oneshot = gt_clockevent_shutdown;

nit: it sounds weird to use the same function as the purpose of the patch is use the new API which is to ventilate those functions (anyway ...)

        clk->set_next_event = gt_clockevent_set_next_event;
        clk->cpumask = cpumask_of(cpu);
        clk->rating = 300;
@@ -184,7 +181,7 @@ static int gt_clockevents_init(struct clock_event_device 
*clk)

  static void gt_clockevents_stop(struct clock_event_device *clk)
  {
-       gt_clockevent_set_mode(CLOCK_EVT_MODE_UNUSED, clk);
+       gt_clockevent_shutdown(clk);
        disable_percpu_irq(clk->irq);
  }


--
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to