On 2015/06/13 4:12, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 12, 2015 at 02:08:13PM +0900, Masami Hiramatsu escreveu:
>> Since commit 5e17b28f1e24 ("perf probe: Add --quiet option to
>> suppress output result message") have replaced printf with pr_info,
>> perf probe -l outputs its result in stderr. However, that is not
>> what the commit expected.
>> e.g.
>> -----
>> # perf probe -l > /dev/null
>> probe:vfs_read (on vfs_read@ksrc/linux-3/fs/read_write.c)
>> -----
>> With this fix,
>> -----
>> # perf probe -l > list
>> # cat list
>> probe:vfs_read (on vfs_read@ksrc/linux-3/fs/read_write.c)
>
> Nope, with this fix just applied:
Oops, I missed to rewrite...
[...]
>> @@ -2200,9 +2220,10 @@ static int __show_perf_probe_events(int fd, bool
>> is_kprobe,
>> goto next;
>> ret = convert_to_perf_probe_event(&tev, &pev,
>> is_kprobe);
>> - if (ret >= 0)
>> - ret = show_perf_probe_event(&pev,
>> - tev.point.module);
>> + if (ret < 0)
>> + goto next;
>> + ret = show_perf_probe_event(&pev, tev.point.module,
>> + false);
>> }
>> next:
>> clear_perf_probe_event(&pev);
>> @@ -2463,7 +2484,7 @@ static int __add_probe_trace_events(struct
>> perf_probe_event *pev,
>> group = pev->group;
>> pev->event = tev->event;
>> pev->group = tev->group;
>> - show_perf_probe_event(pev, tev->point.module);
>> + show_perf_probe_event(pev, tev->point.module, true);
>> /* Trick here - restore current event/group */
>> pev->event = (char *)event;
>> pev->group = (char *)group;
>>
>
These true/false are opposite!
--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
