On 11/06/15 18:31, Ge Gao wrote: > These code looks good to me. > Thanks. > > Best Regards, > > Ge GAO Ge, formal Ack definitely preferred, but thanks for taking a look.
Adriana, please put fixes at the start of such a series. It didn't matter here as the two changes were non overlapping but they take different paths so if there is overlap I need to get the fix out ASAP and then the improvements such as patch 1 can follow slower. Anyhow, applied to the fixes-togreg branch of iio.git (probably to go upstream post the merge window now). Marked for stable. > > > -----Original Message----- > From: Adriana Reus [mailto:adriana.r...@intel.com] > Sent: Friday, June 12, 2015 8:10 AM > To: Ge Gao; ji...@kernel.org > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Adriana Reus > Subject: [PATCH 2/2] iio: inv-mpu: Specify the expected format/precision for > write channels > > The gyroscope needs IIO_VAL_INT_PLUS_NANO for the scale channel and unless > specified write returns MICRO by default. > This needs to be properly specified so that write operations into scale have > the expected behaviour. > > Signed-off-by: Adriana Reus <adriana.r...@intel.com> > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > index 096e545..4de5374 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > @@ -431,6 +431,23 @@ static int inv_mpu6050_write_gyro_scale(struct > inv_mpu6050_state *st, int val) > return -EINVAL; > } > > +static int inv_write_raw_get_fmt(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, long mask) { > + switch (mask) { > + case IIO_CHAN_INFO_SCALE: > + switch (chan->type) { > + case IIO_ANGL_VEL: > + return IIO_VAL_INT_PLUS_NANO; > + default: > + return IIO_VAL_INT_PLUS_MICRO; > + } > + default: > + return IIO_VAL_INT_PLUS_MICRO; > + } > + > + return -EINVAL; > +} > static int inv_mpu6050_write_accel_scale(struct inv_mpu6050_state *st, int > val) { > int result, i; > @@ -702,6 +719,7 @@ static const struct iio_info mpu_info = { > .driver_module = THIS_MODULE, > .read_raw = &inv_mpu6050_read_raw, > .write_raw = &inv_mpu6050_write_raw, > + .write_raw_get_fmt = &inv_write_raw_get_fmt, > .attrs = &inv_attribute_group, > .validate_trigger = inv_mpu6050_validate_trigger, }; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
