On Tue, Jun 16, 2015 at 03:02:50PM -0700, Kees Cook wrote: > On Wed, Mar 11, 2015 at 8:13 PM, Scott Wood <[email protected]> wrote: > > Use %pS for actual addresses, otherwise you'll get bad output > > on arches like ppc64 where %pF expects a function descriptor. > > > > Signed-off-by: Scott Wood <[email protected]> ... > > - seq_printf(s, "%d %08lx %08lx %pf <- %pF\n", > > + seq_printf(s, "%d %08lx %08lx %ps <- %pS\n", ... > Anton, does this look okay to you? (i.e. switching from function > pointer to direct pointer?) vsprintf docs say: > * Note: The difference between 'S' and 'F' is that on ia64 and ppc64 > * function pointers are really function descriptors, which contain a > * pointer to the real address. > > So this seems correct to me. > > Reviewed-by: Kees Cook <[email protected]>
Without questioning the confusing behaviour of "%pF", yes, sure... ack. :) (However, intuitively I'd expect %pF to behave like %pS... but this surely not going to change...) Thanks! Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
