Hi, On 8/17/05, Alan Stern <[EMAIL PROTECTED]> wrote: > On Tue, 16 Aug 2005, Dmitry Torokhov wrote: > > > Alan, > > > > I am sorry I don't have time to properly review the patch at > > themoment, just a couple of comments about serio - I would not look at > > serio for examples of typical use as it was trying very hard to work > > around the original driver model limitation that prevented drivers to > > register childern on the same bus from their probe function. I think > > now that that limitation is lifted serio implemenation can be > > simplified. > > Okay. The same comments may apply to the other users of > device_bind_driver. Apart from a couple in the USB stack that I can > handle already, those users are: > > drivers/pnp/card.c > drivers/input/serio/serio.c > drivers/input/gameport/gameport.c > > Presumably the gameport code is very similar to the serio code. > Interestingly, callers of device_release_driver include: > > drivers/pnp/card.c > drivers/input/serio/serio.c > drivers/input/gameport/gameport.c > drivers/ide/ide-proc.c > drivers/ieee1394/nodemgr.c > > It's not obvious (to me) why ide-proc.c and nodemgr.c call one but not the > other.
ide-proc.c calls device_attach() instead of device_bind_driver() "driver" interface in ide-proc.c will be scheduled for removal since proper bind/unbind sysfs interface is available now. Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
