Hello!
On 17/06/15 23:13, ext York Sun wrote:
> + switch (mux->data.reg_size) {
> + case 4:
> + iowrite32(mux->data.values[chan], mux->data.reg);
> + break;
> + case 2:
> + iowrite16(mux->data.values[chan], mux->data.reg);
> + break;
> + case 1:
> + iowrite8(mux->data.values[chan], mux->data.reg);
> + break;
I'd like to see at least [optional] read-back operation after each write.
And if you stick with iowrite*(), maybe it desires a comment (in the
Documentation/ file?),
that write will be little-Endian, therefore BE users must take care...
Other than that it looks good to me...
--
Best regards,
Alexander Sverdlin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
