On 06/19/2015 04:49 AM, Hanjun Guo wrote:
> On 06/19/2015 06:36 AM, Al Stone wrote:
>> Add the ACPI_SPEC_VERSION() macro to build a proper version number from
>> a major and minor revision number. Add also the ACPI_FADT_SPEC_VERSION
>> that constructs a proper version number from the entries in the current
>> FADT.
>>
>> These macros are added in order to simplify retrieving and comparing ACPI
>> specification version numbers, since this is becoming a more frequent need.
>> In particular, there are some architectures that require at least a certain
>> version of the spec, and there are differences in some structure sizes that
>> have changed with recent versions but can only be tracked by spec version
>> number.
>>
>> Signed-off-by: Al Stone <al.st...@linaro.org>
>> ---
>> include/linux/acpi.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
>> index a4acb55..33ed313 100644
>> --- a/include/linux/acpi.h
>> +++ b/include/linux/acpi.h
>> @@ -48,6 +48,11 @@
>> #include <acpi/acpi_io.h>
>> #include <asm/acpi.h>
>>
>> +#define ACPI_SPEC_VERSION(major, minor) ((major<<8)|minor)
>
> and minor comments for code style
>
> ((major<<8)|minor) - > ((major << 8) | minor)
Ah. Yeah, good idea. I can roll that into next version.
> other than that:
>
> Reviewed-by: Hanjun Guo <hanjun....@linaro.org>
Thanks.
> Thanks
> Hanjun
>
>> +#define ACPI_FADT_SPEC_VERSION \
>> + ACPI_SPEC_VERSION(acpi_gbl_FADT.header.revision, \
>> + acpi_gbl_FADT.minor_revision)
>> +
>> static inline acpi_handle acpi_device_handle(struct acpi_device *adev)
>> {
>> return adev ? adev->handle : NULL;
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
a...@redhat.com
-----------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
