Hi Cyrille, On Fri, Jun 19, 2015 at 10:49:35AM +0200, Cyrille Pitchen wrote: > + > + clk_prepare_enable(clk);
I believe you need to have error handling here, not because it will actually fail but to handle deferrals. > + version = readl(map + FX_VERSION); > + writel(mr, map + FX_MR); > + clk_disable_unprepare(clk); > + > + dev_info(&pdev->dev, "version: %#x, mode: %s\n", version, mode); > + > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > +} Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
