Pavel Machek <[EMAIL PROTECTED]> wrote: > > My patch has been around for quite a while, and no-one else has > > complained, not even you before this point. Plus, you don't seem to be > > complaining about PageSwapCache... nor even PageLocked. > > PageFsMisc really *is* ugly and hard to read. PageLocked etc. look > bad, too but ThIs iS rEaLlY WrOnG.
And PageMappedToDisk()? I disagree. For the most part weird capsage is wrong, but this is readable. Whilst it could make it page_fs_misc() instead, that'd be against the style of the rest of the file, though maybe you want to go through and change all of that too. Maybe you'd prefer bPageFsMisc()? :-) Actually, all these functions should really be called something like IsPageXxxx() to note they're asking a question rather than giving a command. > PageMisc would look less ugly I disagree again. I don't think PageFsMisc() is particularly ugly or unreadable; and it makes it a touch more likely that someone reading code that uses it will notice that it's a miscellaneous flag specifically for filesystem use (you can't rely on them going and looking in the header file for a comment). > , make note in a comment that it is for filesystems only. There should be a comment as well, I suppose. I'll amend the patch for Andrew. All this should also be documented in Documentation/ somewhere too, I suppose. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/