On Mon, Jun 22, 2015 at 11:40:16AM -0300, Arnaldo Carvalho de Melo wrote: SNIP
> > > > +++ b/tools/perf/tests/openat-syscall-tp-fields.c > > > > @@ -45,7 +45,7 @@ int test__syscall_openat_tp_fields(void) > > > > > > > > perf_evsel__config(evsel, &opts); > > > > > > > > - evlist->threads->map[0] = getpid(); > > > > + thread_map__pid(evlist->threads, 0) = getpid(); > > > > > > So this 'function(parms) = something' idiom looks ugly/unfamiliar, can't > > > we keep using: > > > > > > evlist->thread->map[0].pid = getpid(); > > > > hum, I like it more than above line.. what's ugly about that assignment? > > > > I'm adding thread_map__comm to access new 'comm' member, > > so I wanted to introduce easy accessors for both members > > > > get/set functions seem like overkill.. we could use upper case to state > > that it's a macro: > > > > THREAD_MAP__PID(evlist->threads, 0) = getpid(); > > > > anyway I can keep the original way if you insist ;-) > > I really think that > > foo(a, b, c) = bla; > > is ugly :-\ > > *foo(a, b, c) = bla; > > Is uglier tho, bored right now to go beyond aesthetics tho :-\ discussed on irc and decided to go with: thread_map__pid(threads, i) // to get pid thread_map__set_pid(threads, i, pid) // to set pid thread_map__comm(threads, i) // to get comm thread_map__set_comm(threads, i, comm) // to set comm jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
