On 23/06/15 01:08, Yuyang Du wrote: > The per-rq runnable averages (rq->avg) was introduced by Ben with this commit: > > commit 18bf2805d9b30cb823d4919b42cd230f59c7ce1f > Author: Ben Segall <[email protected]> > Date: Thu Oct 4 12:51:20 2012 +0200 > > sched: Maintain per-rq runnable averages > > Since runqueues do not have a corresponding sched_entity we instead embed > a > sched_avg structure directly. > > Signed-off-by: Ben Segall <[email protected]> > Reviewed-by: Paul Turner <[email protected]> > Signed-off-by: Peter Zijlstra <[email protected]> > Link: http://lkml.kernel.org/r/[email protected] > Signed-off-by: Ingo Molnar <[email protected]> > > With CONFIG_FAIR_GROUP_SCHED=y, the rq->avg (runnable_avg_sum, avg_period) is > used to calc the contrib in __update_tg_runnable_avg() for the root group. > > But the root group's load data is never consumed since its merge into kernel > in 2012. The basic reason is we have just one root group, and it is > meaningless to give it weight. As the extra code is in the scheduler's > hot path, so it is better to remove it. > > Signed-off-by: Yuyang Du <[email protected]>
Reviewed-by: Dietmar Eggemann <[email protected]> Tested-by: Dietmar Eggemann <[email protected]> There is an additional clean-up possible since idle_[enter|exit]_fair() are empty now. [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
