On Wed, Jun 24, 2015 at 06:34:18PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcg...@suse.com>
>
> This has no functional changes, it just adjusts
> the ioremap() call for the framebuffer to use
> the same values we later use for the framebuffer,
> this will make it easier to review the next change.
>
> The size of the framebuffer varies but since this is
> for PCI we *know* this defaults to 0x800000.
> atyfb_setup_generic() is *only* used on PCI probe.
>
> Cc: Toshi Kani <toshi.k...@hp.com>
> Cc: Suresh Siddha <sbsid...@gmail.com>
> Cc: Ingo Molnar <mi...@elte.hu>
> Cc: Linus Torvalds <torva...@linux-foundation.org>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: Juergen Gross <jgr...@suse.com>
> Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
> Cc: Andy Lutomirski <l...@amacapital.net>
> Cc: Dave Airlie <airl...@redhat.com>
> Cc: Antonino Daplas <adap...@gmail.com>
> Cc: Jean-Christophe Plagniol-Villard <plagn...@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkei...@ti.com>
> Cc: Ville Syrjälä <syrj...@sci.fi>
> Cc: Rob Clark <robdcl...@gmail.com>
> Cc: Mathias Krause <mini...@googlemail.com>
> Cc: Andrzej Hajda <a.ha...@samsung.com>
> Cc: Mel Gorman <mgor...@suse.de>
> Cc: Vlastimil Babka <vba...@suse.cz>
> Cc: Borislav Petkov <b...@suse.de>
> Cc: Davidlohr Bueso <dbu...@suse.de>
> Cc: linux-fb...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Luis R. Rodriguez <mcg...@suse.com>
> ---
> drivers/video/fbdev/aty/atyfb_base.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/aty/atyfb_base.c
> b/drivers/video/fbdev/aty/atyfb_base.c
> index 16936bb..8025624 100644
> --- a/drivers/video/fbdev/aty/atyfb_base.c
> +++ b/drivers/video/fbdev/aty/atyfb_base.c
> @@ -3489,7 +3489,9 @@ static int atyfb_setup_generic(struct pci_dev *pdev,
> struct fb_info *info,
>
> /* Map in frame buffer */
> info->fix.smem_start = addr;
> - info->screen_base = ioremap(addr, 0x800000);
> + info->fix.smem_len = 0x800000;
> +
> + info->screen_base = ioremap(info->fix.smem_start, info->fix.smem_len);
The framebuffer size isn't always 8MB. That's the size of the BAR. So
this change isn't really correct. I suppose it doesn't hurt too much
since smem_len gets overwritten later in aty_init().
> if (info->screen_base == NULL) {
> ret = -ENOMEM;
> goto atyfb_setup_generic_fail;
> --
> 2.3.2.209.gd67f9d5.dirty
>
--
Ville Syrjälä
syrj...@sci.fi
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
