On Wed, 01 Jul 2015, Krzysztof Kozlowski wrote: > 2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jo...@linaro.org>: > > On Wed, 01 Jul 2015, Lee Jones wrote: > >> On Tue, 30 Jun 2015, Maninder Singh wrote: > >> > >> > o Making pdata NULL check to (!pdata) as coding statndard > >> > and all other checks in file. > >> > o Removing redundant check of pdata, because we already > >> > check for pdata, and also derefernced before this check > >> > > >> > Signed-off-by: Maninder Singh <maninder...@samsung.com> > >> > Reviewed-by: Vaneet Narang <v.nar...@samsung.com> > >> > --- > >> > drivers/mfd/t7l66xb.c | 4 ++-- > >> > 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> Applied, with a properly formatted subject line. > > > > Should have probably been more forthcomming with some advice. > > > > Next time, please use `git log --oneline -- <subsystem>` to see what > > the accepted format is. > > ... and a spell-check could be useful as well :). The reviewed-by tag > was not sent on LKML and the person (Vaneet Narang) was not even CC-ed > so I think it should be dropped.
Fair points. Patch dropped. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/