On Thu, Jul 02, 2015 at 10:19:07AM +0300, Andrey Ryabinin wrote:
> On 07/02/2015 07:10 AM, Al Viro wrote:
> >>
> >> It should be easy to confirm - in p9_client_prepare_req() add
> >> if (WARN_ON_ONCE(tag != (u16)tag)) {
> >> p9_idpool_put(tag, c->tagpool);
> >> return ERR_PTR(-ENOMEM);
> >> }
> >> right after
> >> tag = p9_idpool_get(c->tagpool);
> >> if (tag < 0)
> >> return ERR_PTR(-ENOMEM);
> >>
> >> and see if it triggers. I'm not sure if failing with ENOMEM is the
> >> right response (another variant is to sleep there until the pile
> >> gets cleaned or until we get killed), and WARN_ON_ONCE() is definitely
> >> not for the real work, but it will do for confirming that this is what
> >> we are hitting.
> >
>
> Apparently, I'm seeing something else. That WARN_ON_ONCE didn't trigger.
While the one in p9_client_write() (on rsize < count) did?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
