On Thu 02 Jul 09:19 PDT 2015, Stephen Boyd wrote:
> On 06/30/2015 12:46 PM, Bjorn Andersson wrote:
> > +
> > +int __qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t
> > size)
> > +{
> > + dma_addr_t mdata_phys;
> > + void *mdata_buf;
> > + u32 scm_ret;
> > + int ret;
> > + struct pas_init_image_req {
> > + u32 proc;
> > + u32 image_addr;
>
> Please mark these as __le32 and do the appropriate conversions to little
> endian.
Just out of curiosity, are there any big endian systems out there that
will run this code?
Either way I will fix this, to follow the style of the other parts of
this file.
> Also consider removing the struct name and just make it
> anonymous, i.e.
>
> struct {
> __le32 proc;
> __le32 image_addr;
> } cmd;
>
Right, there's no reason to name these.
Thanks,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
