On Thursday 02 July 2015 15:10:39 Alex Hung wrote: > Thanks for the support. I will create v3 based with LED triggers. > > Just for information. ASUS's wording is as below: > > Fn+F2 can be used to turn on or off all radio capabilities in the > device (as known as airplane mode switch). I don't have any > preferences on the name. We may use the term airplane-mode do if > asus-rbtn is not preferred. Let me know if there are any suggestions. >
This is OK, but I though that ACPI ATK4001 device is some multifunctional device, which is doing more then LED control... (At least I understand it from your comments). So in this case I would not call driver led/radio related. Right? > > On Wed, Jul 1, 2015 at 7:48 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > > On Wednesday 01 July 2015 00:09:41 Alex Hung wrote: > >> ATK4001 is an independent ACPI device, and Method(HSWC) is its method > >> to control LED (actually it has other functions but only LED is needed > >> so far). > > > > If this driver is for supporting ACPI ATK4001 device (which has couple > > of methods, not only LED) it is really good idea to name it asus-rbtn? > > > > Darren, you as maintainer of platform drivers, what do you think? I > > believe in future this driver will be extended to support more functions > > and so name asus-rbtn will be confusing. > > > > -- > > Pali Rohár > > pali.ro...@gmail.com > -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
