* Grygorii Strashko <grygorii.stras...@ti.com> [150706 08:16]:
> The PSC IRQ is requested using request_irq() API and as result it can
> be forced to be threaded IRQ in RT-Kernel if PCS_QUIRK_HAS_SHARED_IRQ
> is enabled for pinctrl domain.
> 
> As result, following 'possible irq lock inversion dependency' report
> can be seen:
...
 
> To fix it use IRQF_NO_THREAD to ensure that pcs irq will not be forced 
> threaded.
> 
> Cc: Tony Lindgren <t...@atomide.com>
> Cc: Sebastian Andrzej Siewior <bige...@linutronix.de>
> Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com>
> ---
>  drivers/pinctrl/pinctrl-single.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-single.c 
> b/drivers/pinctrl/pinctrl-single.c
> index b2de09d..0b8d480 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1760,7 +1760,8 @@ static int pcs_irq_init_chained_handler(struct 
> pcs_device *pcs,
>               int res;
>  
>               res = request_irq(pcs_soc->irq, pcs_irq_handler,
> -                               IRQF_SHARED | IRQF_NO_SUSPEND,
> +                               IRQF_SHARED | IRQF_NO_SUSPEND |
> +                               IRQF_NO_THREAD,
>                                 name, pcs_soc);
>               if (res) {
>                       pcs_soc->irq = -1;

Looks OK to me. The only case this would be a problem if a system has
a huge number of wake-up events as the list of status registers to
check could grow to the number of GPIO pins in theory. Anyways,
feel free to add:

Acked-by: Tony Lindgren <t...@atomide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to