On Wed, Jul 01, 2015 at 05:13:14AM +0100, Pi-Cheng Chen wrote:
> Sorry for the mistake I made when cherry-picking the patch. Fix and resend
> again.
>
> __cpufreq_cooling_register() might fail if some CPU other than first one in
> clip_cpu mask is present earlier e.g. CPU hotplug. Iterate all CPUs in the
> mask
> to handle this case.
>
> Signed-off-by: Pi-Cheng Chen <pi-cheng.c...@linaro.org>
Looks good to me. FWIW,
Acked-by: Javi Merino <javi.mer...@arm.com>
> ---
> drivers/thermal/cpu_cooling.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 6509c61..5e90eb6 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -776,9 +776,14 @@ __cpufreq_cooling_register(struct device_node *np,
> char dev_name[THERMAL_NAME_LENGTH];
> struct cpufreq_frequency_table *pos, *table;
> unsigned int freq, i, num_cpus;
> - int ret;
> + int ret, cpu;
> +
> + for_each_cpu(cpu, clip_cpus) {
> + table = cpufreq_frequency_get_table(cpu);
> + if (table)
> + break;
> + }
>
> - table = cpufreq_frequency_get_table(cpumask_first(clip_cpus));
> if (!table) {
> pr_debug("%s: CPUFreq table not found\n", __func__);
> return ERR_PTR(-EPROBE_DEFER);
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
