On Thu, Jul 9, 2015 at 12:29 PM, Joe Perches <[email protected]> wrote: > On Thu, 2015-07-09 at 10:39 +0200, Geert Uytterhoeven wrote: >> On Wed, Jul 8, 2015 at 3:54 PM, Pavel Machek <[email protected]> wrote: >> > Apparently, new tools are needed in the community, as normal review >> > comments did not stop drivers/android/binder.c merge. >> > >> > For example binder_transaction does not exactly look like a kernel >> > code, "TODO: fput" does not really invoke confidence, and amount of >> > BUG_ON()s is quite amazing... >> >> Amazingly, checkpatch (without --strict) only complains about long lines. >> >> Seems like the test for "BUG" is (and always has been) commented out... > > Maybe (requires --strict when scanning files) > --- > scripts/checkpatch.pl | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-)
Thanks! Detected 31 occurrences (+ 1 commented out), shudder... Tested-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
