On Thu, Jul 09, 2015 at 06:11:30PM +0530, Vaibhav Hiremath wrote:

> +/* dummy table */
> +static const struct regulator_linear_range buck_volt_range_dummy[] = {
> +};

I don't understand this, it certainly doesn't look very healthy and
would need more documentation.

> +/* dummy table */
> +static const unsigned int ldo_volt_table_dummy[] = {
> +};

Likewise.

> -     ret = of_regulator_match(&pdev->dev, np,
> -                              pm800_regulator_matches,
> -                              ARRAY_SIZE(pm800_regulator_matches));
> -     if (ret < 0)
> +     ret = of_regulator_match(&pdev->dev, np, *regulator_matches, range);
> +     if (ret < 0) {
> +             dev_err(&pdev->dev, "Error parsing regulator init data: %d\n", 
> ret);
>               return ret;
> +     }

Can you convert the driver to use the more modern core matching code
(setting of_match in the driver struct)?  That should simplify this
change.

Attachment: signature.asc
Description: Digital signature

Reply via email to