Le 10/07/2015 14:31, Maxime Ripard a écrit : > On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: >> Hi, >> >> On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : >>> I would agree with Maxime. Currently all latest chip reset function is >>> compatible with the atmel,sama5d3-rstc. >>> So check compatible string is enough for now. >>> But of cause if we have other incompatible reset in future with new chip, >>> the structure like you said is needed. >> >> We managed to avoid using of_machine_is_compatible() in all the at91 >> drivers. I'd like to keep it that way. It was painful enough to remove >> all those cpu_is_at91xxx calls. > > That's your call... > >> Also, using it is trying to match strings and will result in longer boot >> times. > > Have you looked at the implementation of of_match_device? If that's > really a concern to you, you should actually avoid it.
I agree: let's keep it simple and use of_match_device(). Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
