Thanks for this, I'm sending a v2 shortly. On Friday 07/03 at 09:00 -0700, Christoph Hellwig wrote: > On Mon, Jun 08, 2015 at 08:50:55PM -0700, Calvin Owens wrote: > > This refactors the fw_event code to use the new refcount. > > I spent some time looking over this code because it's so convoluted. > In general I think code should either embeed one work_struct (and it > really doesn't seem to need a delayed work here!) or if needed a list > and not both like this one. But it's probably too much work to sort > all this out, so let's go with your version.
Yeah, I tried to get rid of fw_event_list altogether, since I think what cleanup_queue() does could be simplified to calling flush_workqueue(). The problem is _scsih_check_topo_delete_events(), which looks at the list and sometimes marks fw_events as "ignored" so they aren't executed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
