On Wed, 24 Aug 2005 11:22:52 -0700, Andrew Vasquez <[EMAIL PROTECTED]> wrote: >On Wed, 24 Aug 2005, Keith Owens wrote: > >> 2.6.13-rc7 + kdb on ia64. The qla2xxx drivers are getting unaligned >> accesses at startup. >> >> qla2300 0000:01:02.0: Found an ISP2312, irq 66, iobase 0xc00000080f300000 >> qla2300 0000:01:02.0: Configuring PCI space... >> PCI: slot 0000:01:02.0 has incorrect PCI cache line size of 0 bytes, >> correcting to 128 >> qla2300 0000:01:02.0: Configure NVRAM parameters... >> qla2300 0000:01:02.0: Verifying loaded RISC code... >> qla2300 0000:01:02.0: Waiting for LIP to complete... >> qla2300 0000:01:02.0: Cable is unplugged... >> scsi1 : qla2xxx >> kernel unaligned access to 0xe00000300667800c, ip=0xa0000001005cd0b1 > >Yes, I have a fix for this in my patch-queue. I'll attach it here for >reference. I'll forward onto linux-scsi post 2.6.13. > >-- >av > >--- > >On some platforms the hard-casting of the 8 byte node_name >and port_name arrays to an u64 would cause unaligned-access >warnings. Generalize the conversions with consistent >shifting of WWN bytes. > >Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> >--- > > drivers/scsi/qla2xxx/qla_attr.c | 27 +++++++++++++++++---------- > 1 files changed, 17 insertions(+), 10 deletions(-) > >24e16c86578498fd71a3e33bebbd8be7323a03c6 >diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c >--- a/drivers/scsi/qla2xxx/qla_attr.c >+++ b/drivers/scsi/qla2xxx/qla_attr.c >@@ -345,6 +345,15 @@ struct class_device_attribute *qla2x00_h > > /* Host attributes. */ > >+static u64 >+wwn_to_u64(uint8_t *wwn) >+{ >+ return (u64)wwn[0] << 56 | (u64)wwn[1] << 48 | >+ (u64)wwn[2] << 40 | (u64)wwn[3] << 32 | >+ (u64)wwn[4] << 24 | (u64)wwn[5] << 16 | >+ (u64)wwn[6] << 8 | (u64)wwn[7]; >+} >+
Any reason you defined your own function instead of using the standard get_unaligned()? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/